Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LLVMBasedAliasAnalysis #610

Draft
wants to merge 9 commits into
base: development
Choose a base branch
from

Conversation

fabianbs96
Copy link
Member

@fabianbs96 fabianbs96 commented Apr 14, 2023

LLVM has removed their CFL based alias analysis implementations (CFLAndersAA and CFLSteensAA -- https://reviews.llvm.org/D139703), so we should remove their uses as well. This also removes some bugs due to known crashes of both CFL AA for some larger target programs.

#329

@fabianbs96 fabianbs96 self-assigned this Apr 14, 2023
@fabianbs96 fabianbs96 marked this pull request as ready for review April 14, 2023 16:06
@fabianbs96 fabianbs96 requested a review from MMory as a code owner April 14, 2023 16:06
@fabianbs96 fabianbs96 added cleanup external bug A bug in depending code labels Apr 14, 2023
@fabianbs96 fabianbs96 requested a review from vulder April 14, 2023 16:22
@vulder
Copy link
Collaborator

vulder commented Apr 18, 2023

@fabianbs96 @MMory you should discuss internally what's a good way forward from this. Loosing these AA algorithms reduces phasars precision, so we probably need some form of replacement algorithms that ship with phasar.

@fabianbs96 fabianbs96 added the blocked A prerequisite for this ticket prevents it from being worked on label Apr 22, 2023
@fabianbs96 fabianbs96 marked this pull request as draft April 22, 2023 16:01
@fabianbs96
Copy link
Member Author

As agreed we won't merge this PR until we have a proper replacement for the CFLAndersAA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked A prerequisite for this ticket prevents it from being worked on cleanup external bug A bug in depending code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants